Skip to content

feat(i18n): add missing ar-EG and fr-FR translation keys#2315

Merged
serhalp merged 4 commits intonpmx-dev:mainfrom
hamdibenjarrar:main
Mar 29, 2026
Merged

feat(i18n): add missing ar-EG and fr-FR translation keys#2315
serhalp merged 4 commits intonpmx-dev:mainfrom
hamdibenjarrar:main

Conversation

@hamdibenjarrar
Copy link
Copy Markdown
Contributor

Summary

Adds 314 missing translation keys for the Egyptian Arabic locale (ar-EG).

Sections covered

  • footer (blog, builders_chat, brand)
  • shortcuts, search (instant search keys)
  • blog + all AT Protocol / Bluesky comment keys
  • settings (accent colors, background themes, keyboard shortcuts)
  • error, common (including all view_on.* git platforms)
  • profile, package (size, docs, versions, trends, downloads, metrics)
  • compare (full diff/version comparison UI)
  • pds, translation_status, action_bar, logo_menu, brand
  • claim, code, filters, about, auth, header

Notes

  • Uses Modern Standard Arabic natural to Egyptian Arabic speakers
  • Proper Arabic pluralization (singular / dual / plural) where applicable
  • Technical terms (SVG, PNG, Markdown, WebAssembly, CLI) kept as-is
  • All interpolation placeholders ({name}, {count}, etc.) preserved

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Mar 29, 2026 2:03pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 29, 2026 2:03pm
npmx-lunaria Ignored Ignored Mar 29, 2026 2:03pm

Request Review

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @hamdibenjarrar! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 29, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ar-EG.json Localization changed, will be marked as complete.
i18n/locales/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90457a8a-3121-4acc-a51c-00d0dcf25df1

📥 Commits

Reviewing files that changed from the base of the PR and between 0bc148e and 8972153.

📒 Files selected for processing (1)
  • i18n/locales/fr-FR.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • i18n/locales/fr-FR.json

📝 Walkthrough

Walkthrough

This PR expands i18n/locales/ar-EG.json from a single $schema field to ~441 added Arabic (Egypt) translation entries across many top-level namespaces (footer, shortcuts, search, blog, settings, error, common, profile, package, claim, code, filters, about, auth, header, compare, pds, translation_status, action_bar, logo_menu, brand). Entries include nested keys, ICU-style pluralisation and parameter placeholders (e.g. {count}, {name}, {version}, {from}, {to}). The $schema declaration formatting was adjusted to accommodate the additions.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
  • graphieros
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes the changeset, detailing the 314 missing translation keys added for Egyptian Arabic (ar-EG) locale with specific sections covered and implementation notes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1bd96032-ba0c-4cf2-84c8-0b645f37bb50

📥 Commits

Reviewing files that changed from the base of the PR and between 7688cd7 and f23f805.

📒 Files selected for processing (1)
  • i18n/locales/ar-EG.json

@hamdibenjarrar hamdibenjarrar changed the title i18n(ar-EG): add 314 missing translation keys for Egyptian Arabic feat(ar-EG): add 314 missing translation keys for Egyptian Arabic Mar 29, 2026
@hamdibenjarrar hamdibenjarrar changed the title feat(ar-EG): add 314 missing translation keys for Egyptian Arabic feat(i18n): add ar-EG (Egyptian Arabic) translation keys Mar 29, 2026
@hamdibenjarrar hamdibenjarrar changed the title feat(i18n): add ar-EG (Egyptian Arabic) translation keys feat(i18n): add missing ar-EG and fr-FR translation keys Mar 29, 2026
Copy link
Copy Markdown
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French translations LGTM. Thank you!

Any Arabic reviewers? 👀

Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
@hamdibenjarrar
Copy link
Copy Markdown
Contributor Author

Thank you @serhalp for the review and approval! 🙏

Good point on skills_cli — keeping it as "Skills CLI" makes sense since it's a technical term. Applied your suggestion!

@hamdibenjarrar
Copy link
Copy Markdown
Contributor Author

As a native Arabic speaker, I can confirm the ar-EG translations are accurate and natural. The plural forms follow correct Arabic CLDR rules (6 forms: zero/one/two/few/many/other), and the terminology is appropriate for Egyptian Arabic. ✅

@serhalp serhalp added this pull request to the merge queue Mar 29, 2026
Merged via the queue into npmx-dev:main with commit e2a7b59 Mar 29, 2026
23 of 31 checks passed
@github-actions
Copy link
Copy Markdown

Thanks for your first contribution, @hamdibenjarrar! 🙌

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants