fix(i18n): add missing keys to de translations#2475
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
de.jsonde.json
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the German localisation file (i18n/locales/de.json) by adding numerous German strings for a command palette and keyboard shortcuts, expanding common UI labels (yes/no, parameterised collapse/expand), adding chart/trends and compare UI copy (including quadrant chart text), facet bulk-selection labels, code browser action labels, branding/localisation entries (logo_menu, brand, alt_logo_kawaii, settings.accent_colors.neutral), and a capitalization fix for package.versions.title. Total diff: +209/−9. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
i18n/locales/de.json (1)
1624-1625: Minor capitalisation inconsistency with other section headings.The
headingvalue uses capitalised"Marke", whereas other sections in this file use lowercase for their headings (e.g.,"über uns"at line 1091,"barrierefreiheit"at line 1526,"befehlspalette"at line 83).Consider using lowercase
"marke"to maintain consistency with the established stylistic convention, unless the capitalisation is intentional for brand-related content.💅 Suggested change for consistency
"brand": { - "title": "Marke", - "heading": "Marke", + "title": "marke", + "heading": "marke",
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a2b9e54b-d4cc-4f57-afa9-4a3ddabe4c2d
📒 Files selected for processing (1)
i18n/locales/de.json
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
de.json
🔗 Linked issue
N/A
🧭 Context
German translation currently lacks 157 keys for full coverage as reported by https://npmx.dev/translation-status
Added missing keys to
de.json📚 Description
Added all 157 missing German translations to
de.json. Followed the i18n contribution guide to ensure formatting and compatibility.