Skip to content

fix(i18n): add missing keys to de translations#2475

Merged
ghostdevv merged 3 commits intonpmx-dev:mainfrom
t128n:main
Apr 12, 2026
Merged

fix(i18n): add missing keys to de translations#2475
ghostdevv merged 3 commits intonpmx-dev:mainfrom
t128n:main

Conversation

@t128n
Copy link
Copy Markdown
Contributor

@t128n t128n commented Apr 11, 2026

🔗 Linked issue

N/A

🧭 Context

German translation currently lacks 157 keys for full coverage as reported by https://npmx.dev/translation-status

Added missing keys to de.json

📚 Description

Added all 157 missing German translations to de.json. Followed the i18n contribution guide to ensure formatting and compatibility.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Apr 11, 2026 1:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 11, 2026 1:40pm
npmx-lunaria Ignored Ignored Apr 11, 2026 1:40pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 11, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/de.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@t128n t128n changed the title feat(i18n): Add missing keys to de.json feat(i18n): add missing keys to de.json Apr 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c846f262-cc03-4b0a-b215-ac970fad556a

📥 Commits

Reviewing files that changed from the base of the PR and between 574781b and 80d9b20.

📒 Files selected for processing (1)
  • i18n/locales/de.json

📝 Walkthrough

Walkthrough

This PR updates the German localisation file (i18n/locales/de.json) by adding numerous German strings for a command palette and keyboard shortcuts, expanding common UI labels (yes/no, parameterised collapse/expand), adding chart/trends and compare UI copy (including quadrant chart text), facet bulk-selection labels, code browser action labels, branding/localisation entries (logo_menu, brand, alt_logo_kawaii, settings.accent_colors.neutral), and a capitalization fix for package.versions.title. Total diff: +209/−9.

Possibly related PRs

Suggested reviewers

  • danielroe
  • trueberryless
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, explaining the addition of 157 missing German translation keys to de.json following the i18n contribution guide.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
i18n/locales/de.json (1)

1624-1625: Minor capitalisation inconsistency with other section headings.

The heading value uses capitalised "Marke", whereas other sections in this file use lowercase for their headings (e.g., "über uns" at line 1091, "barrierefreiheit" at line 1526, "befehlspalette" at line 83).

Consider using lowercase "marke" to maintain consistency with the established stylistic convention, unless the capitalisation is intentional for brand-related content.

💅 Suggested change for consistency
   "brand": {
-    "title": "Marke",
-    "heading": "Marke",
+    "title": "marke",
+    "heading": "marke",

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a2b9e54b-d4cc-4f57-afa9-4a3ddabe4c2d

📥 Commits

Reviewing files that changed from the base of the PR and between 0164064 and ea61002.

📒 Files selected for processing (1)
  • i18n/locales/de.json

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv changed the title feat(i18n): add missing keys to de.json fix(i18n): add missing keys to de translations Apr 12, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Apr 12, 2026
Merged via the queue into npmx-dev:main with commit 655ae5b Apr 12, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants