Skip to content

Conversation

@lino-levan
Copy link
Contributor

Readme content without a specified language would have their background color hard-set to black in light mode, which results in black-on-black text.

There's one section that specifies this:

.readme-content pre code,
.readme-content .shiki code {
  background: transparent !important;
  border: none;
  padding: 0;
  @apply font-mono;
  font-size: 0.875rem;
  color: var(--fg);
  /* Prevent code from forcing width */
  white-space: pre;
  word-break: normal;
  overflow-wrap: normal;
}

above which is correct

and then another section that does

/* Code blocks - including Shiki output */
.readme-content pre,
.readme-content .shiki {
  background: oklch(0.145 0 0) !important;
  border: 1px solid var(--border);
  border-radius: 8px;
  padding: 1rem;
  overflow-x: auto;
  margin: 1.5rem 0;
  /* Fix horizontal overflow */
  max-width: 100%;
  box-sizing: border-box;
}

which incorrectly over-rode the transparent background.

Screenshots

See https://npmx.dev/deno-std as an example.

Before

image image

After

image image

@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 28, 2026 9:52pm
npmx-lunaria Ready Ready Preview, Comment Jan 28, 2026 9:52pm
npmx.dev Ready Ready Preview, Comment Jan 28, 2026 9:52pm

Request Review

@danielroe danielroe added this pull request to the merge queue Jan 28, 2026
@43081j
Copy link
Collaborator

43081j commented Jan 28, 2026

@lino-levan i can't recreate this, can you give any more information?

here's what i see in dark mode on the live site:

image

@lino-levan
Copy link
Contributor Author

Look at the PR description (specifically before and after), this only reproduces in light mode.

@43081j
Copy link
Collaborator

43081j commented Jan 28, 2026

aha sorry, i absolutely did read the description and always will. i also saw the before and after. but somehow got things muddled up this time

nevermind 👍

@lino-levan
Copy link
Contributor Author

All good! I've done similar in the past – didn't mean to imply you hadn't read the description – just wanted to suggest another readthrough.

Merged via the queue into npmx-dev:main with commit cd780ec Jan 28, 2026
12 checks passed
fatfingers23 pushed a commit to fatfingers23/npmx.dev that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants