fix: add deduplication logic in tree sprite generation#2600
fix: add deduplication logic in tree sprite generation#2600gioboa wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as resolved.
This comment was marked as resolved.
|
We did #2586 yesterday, does this do something that that doesn't? 😅 |
|
My bad, you are right. Thanks 🙏 |
🔗 Linked issue
Close #2558
🧭 Context
SVGs with duplicated IDs are not working correctly on Safari and Firefox.
📚 Description
Added a small logic to keep the ID unique.