Skip to content

fix: add deduplication logic in tree sprite generation#2600

Closed
gioboa wants to merge 1 commit intonpmx-dev:mainfrom
gioboa:fix/2558-bis
Closed

fix: add deduplication logic in tree sprite generation#2600
gioboa wants to merge 1 commit intonpmx-dev:mainfrom
gioboa:fix/2558-bis

Conversation

@gioboa
Copy link
Copy Markdown

@gioboa gioboa commented Apr 20, 2026

🔗 Linked issue

Close #2558

🧭 Context

SVGs with duplicated IDs are not working correctly on Safari and Firefox.

📚 Description

Added a small logic to keep the ID unique.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 20, 2026 1:49pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 20, 2026 1:49pm
npmx-lunaria Ignored Ignored Apr 20, 2026 1:49pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d22d535-6a56-46bf-b9b6-5e47bd21f3a9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

This comment was marked as resolved.

@ghostdevv
Copy link
Copy Markdown
Contributor

We did #2586 yesterday, does this do something that that doesn't? 😅

@gioboa
Copy link
Copy Markdown
Author

gioboa commented Apr 20, 2026

My bad, you are right. Thanks 🙏

@gioboa gioboa closed this Apr 20, 2026
@gioboa gioboa deleted the fix/2558-bis branch April 20, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File tree LICENSE icon doesn't render

2 participants