docs(ui): add stories for Error page#2601
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a new Storybook stories file that registers the error.vue component and defines seven stories demonstrating different HTTP status variants (404, 401, 500, 503, 418) and two message-focused scenarios (short and long messages). Changes
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/error.stories.ts`:
- Around line 43-58: The stories currently exercise only the default branches
(statuses 502 and 418); add coverage for the dedicated 503 branch in
app/error.vue by either changing the existing BadGateway story's error.status
from 502 to 503 or by adding a new Story export (e.g., ServiceUnavailable or
ServiceUnavailable503) with args.error.status = 503 (typed as NuxtError) so
Storybook/Chromatic/a11y will render the 503-specific UI; update the export name
if you add a new story and ensure it follows the same pattern as
BadGateway/Teapot.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 230e5cbd-c3ed-4cad-aceb-b81338624874
📒 Files selected for processing (1)
app/error.stories.ts
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
🔗 Linked issue
#2150
🧭 Context
This would enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.
📚 Description
Adds stories for Error page.