Skip to content

docs(ui): add stories for Error page#2601

Merged
ghostdevv merged 3 commits intonpmx-dev:mainfrom
cylewaitforit:sb-error-page
Apr 20, 2026
Merged

docs(ui): add stories for Error page#2601
ghostdevv merged 3 commits intonpmx-dev:mainfrom
cylewaitforit:sb-error-page

Conversation

@cylewaitforit
Copy link
Copy Markdown
Contributor

@cylewaitforit cylewaitforit commented Apr 20, 2026

🔗 Linked issue

#2150

🧭 Context

This would enable a storybook mock page, storybook a11y checks, and chromatic visual regression tests for this page as documented by the storybook stories.

📚 Description

Adds stories for Error page.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 20, 2026 3:59pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 20, 2026 3:59pm
npmx-lunaria Ignored Ignored Apr 20, 2026 3:59pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e49876ff-f892-4c1a-86d0-a47f0f948397

📥 Commits

Reviewing files that changed from the base of the PR and between 95b7625 and 3ae631c.

📒 Files selected for processing (1)
  • app/error.stories.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/error.stories.ts

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Added comprehensive Storybook documentation for error page display scenarios, covering HTTP status variants (404, 401, 500, 503, 418) and message rendering with different content lengths.

Walkthrough

Adds a new Storybook stories file that registers the error.vue component and defines seven stories demonstrating different HTTP status variants (404, 401, 500, 503, 418) and two message-focused scenarios (short and long messages).

Changes

Cohort / File(s) Summary
Error Component Stories
app/error.stories.ts
New Storybook file exporting meta and seven stories: NotFound (404), Unauthorized (401), ServerError (500), ServiceUnavailable (503), Teapot (418), WithMessage (404 with short message), and LongMessage (500 with long message).

Suggested reviewers

  • ghostdevv
  • JReinhold
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding Storybook stories for the Error page component.
Description check ✅ Passed The description is related to the changeset, explaining the purpose of adding Error page stories for Storybook documentation and testing.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@cylewaitforit cylewaitforit marked this pull request as ready for review April 20, 2026 15:49
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/error.stories.ts`:
- Around line 43-58: The stories currently exercise only the default branches
(statuses 502 and 418); add coverage for the dedicated 503 branch in
app/error.vue by either changing the existing BadGateway story's error.status
from 502 to 503 or by adding a new Story export (e.g., ServiceUnavailable or
ServiceUnavailable503) with args.error.status = 503 (typed as NuxtError) so
Storybook/Chromatic/a11y will render the 503-specific UI; update the export name
if you add a new story and ensure it follows the same pattern as
BadGateway/Teapot.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 230e5cbd-c3ed-4cad-aceb-b81338624874

📥 Commits

Reviewing files that changed from the base of the PR and between 8b5edf2 and 95b7625.

📒 Files selected for processing (1)
  • app/error.stories.ts

Comment thread app/error.stories.ts Outdated
Comment thread app/error.stories.ts Outdated
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
@ghostdevv ghostdevv added this pull request to the merge queue Apr 20, 2026
Merged via the queue into npmx-dev:main with commit d12559c Apr 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants