Skip to content

fix: pin version for version for dev install when Trust downgrade is noticed#2644

Open
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override
Open

fix: pin version for version for dev install when Trust downgrade is noticed#2644
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:fix-override

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

@gameroman gameroman commented Apr 27, 2026

Closes #2643

Before

image

After

image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 29, 2026 3:34pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 29, 2026 3:34pm
npmx-lunaria Ignored Ignored Apr 29, 2026 3:34pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 11d16755-7e27-4133-aa6a-7c0cf7672169

📥 Commits

Reviewing files that changed from the base of the PR and between 6cf0470 and 11413c1.

📒 Files selected for processing (1)
  • app/components/Terminal/Install.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/components/Terminal/Install.vue

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Dev install command generation now respects a version override when provided, so displayed install commands reflect the chosen version.
    • Clipboard copy behaviour corrected so copied dev install commands match the overridden/version selected by the user.

Walkthrough

The Terminal Install component now uses installVersionOverride when non-null as the version value for building dev install command parts and for copying the dev install command, replacing the previous unconditional use of requestedVersion.

Changes

Cohort / File(s) Summary
Version preference logic
app/components/Terminal/Install.vue
Updated getDevInstallPartsForPM and copyDevInstallCommand to pass installVersionOverride ?? requestedVersion as the version argument to getInstallCommandParts/getInstallCommand, ensuring the override is respected when present.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: pinning the version for dev install when a Trust downgrade is noticed, matching the PR's primary objective.
Description check ✅ Passed The description is related to the changeset, providing a before/after comparison that illustrates the version pinning fix for dev installations.
Linked Issues check ✅ Passed The PR successfully implements the fix for issue #2643 by updating both getDevInstallPartsForPM and copyDevInstallCommand to respect installVersionOverride, ensuring dev installs are pinned to the correct version.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the linked issue #2643; modifications to the Terminal/Install.vue component solely address the version pinning logic for dev installations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@gameroman gameroman changed the title fix: override for dev fix: pin version for version for dev install when Trust downgrade is noticed Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Terminal/Install.vue 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: when Trust downgrade is noticed, the install version is not pinned for dev install

1 participant