feat: press freedom day noodle#2666
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe PR replaces the Artemis noodle feature with a new Press noodle. The Artemis logo component is removed, a new Press logo component is introduced featuring World Press Freedom Day information, the active noodle configuration is updated to the Press entry, and accessibility tests are updated to validate the new component. ChangesNoodle Feature Replacement
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
I love it :) |
|
Thank you @graphieros, good point. It was more of a lead-in to the second sentence, but it sounds better without it |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/nuxt/a11y.spec.ts (1)
363-374: 💤 Low valueConsider distinguishing the two
Noodlestest descriptions.Both tests carry the exact same description
'should have no accessibility violations', so a failure is ambiguous in CI output.✏️ Proposed fix
describe('Noodles', () => { - it('should have no accessibility violations', async () => { + it('NoodleKawaiiLogo should have no accessibility violations', async () => { const component = await mountSuspended(NoodleKawaiiLogo) const results = await runAxe(component) expect(results.violations).toEqual([]) }) - it('should have no accessibility violations', async () => { + it('NoodlePressLogo should have no accessibility violations', async () => { const component = await mountSuspended(NoodlePressLogo) const results = await runAxe(component) expect(results.violations).toEqual([]) }) })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@test/nuxt/a11y.spec.ts` around lines 363 - 374, Change the duplicate test titles under describe('Noodles') so failures are unambiguous: update the two it(...) descriptions to mention the specific component names (e.g., "NoodleKawaiiLogo should have no accessibility violations" and "NoodlePressLogo should have no accessibility violations") while keeping the test bodies (mountSuspended(NoodleKawaiiLogo / NoodlePressLogo), runAxe, and expect(results.violations).toEqual([])) unchanged; locate the tests by the describe('Noodles') block and the references to NoodleKawaiiLogo, NoodlePressLogo, mountSuspended, and runAxe.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@test/nuxt/a11y.spec.ts`:
- Around line 363-374: Change the duplicate test titles under
describe('Noodles') so failures are unambiguous: update the two it(...)
descriptions to mention the specific component names (e.g., "NoodleKawaiiLogo
should have no accessibility violations" and "NoodlePressLogo should have no
accessibility violations") while keeping the test bodies
(mountSuspended(NoodleKawaiiLogo / NoodlePressLogo), runAxe, and
expect(results.violations).toEqual([])) unchanged; locate the tests by the
describe('Noodles') block and the references to NoodleKawaiiLogo,
NoodlePressLogo, mountSuspended, and runAxe.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c2e24d52-9ab2-4305-b9c4-af16fc34eba7
⛔ Files ignored due to path filters (2)
public/extra/npmx-dark-press.pngis excluded by!**/*.pngpublic/extra/npmx-light-press.pngis excluded by!**/*.png
📒 Files selected for processing (4)
app/components/Noodle/Artemis/Logo.vueapp/components/Noodle/Press/Logo.vueapp/components/Noodle/index.tstest/nuxt/a11y.spec.ts
💤 Files with no reviewable changes (1)
- app/components/Noodle/Artemis/Logo.vue
graphieros
left a comment
graphieros
left a comment
There was a problem hiding this comment.
Looks beautiful to me 🌿
3 participants
🔗 Linked issue
A new noodle dedicated to World Press Freedom Day
The press has been shedding light on events throughout history - reporting, investigating, raising critical issues, and revealing defining moments of our past. Journalists don’t just give a part of themselves; they often risk their lives and their freedom.
In recent years, press freedom has been in decline. And when it falls, it leads to a loss of freedom for everyone - creating a cycle that only deepens over time.
This is a small noodle to once again highlight the importance of journalism. In the background, you can find several key articles from our history, many of which led to significant change
Background for nerds
(See all in figma)