Skip to content

fix(i18n): update zh-CN locale#2712

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
BabyLy233:zh-CN
May 11, 2026
Merged

fix(i18n): update zh-CN locale#2712
danielroe merged 1 commit into
npmx-dev:mainfrom
BabyLy233:zh-CN

Conversation

@BabyLy233
Copy link
Copy Markdown
Contributor

🔗 Linked issue

🧭 Context

zh-CN is missing 48 values.

📚 Description

Update zh-CN.json with pnpm i18n:check:fix zh-CN

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment May 11, 2026 7:12am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview May 11, 2026 7:12am
npmx-lunaria Ignored Ignored May 11, 2026 7:12am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Single Chinese localisation file updated with 64 new and modified translation keys spanning footer navigation, package metrics (size decrease, replacement options, ranking), README error handling, version licence tracking, comprehensive timeline feature strings, and leaderboard module UI text.

Changes

Chinese Localisation Update

Layer / File(s) Summary
Navigation & Shortcuts
i18n/locales/zh-CN.json
Footer section keys expanded from brand to include resources, features, and other categories. Shortcuts section adds open_timeline for timeline entry point.
Common UI Utilities
i18n/locales/zh-CN.json
Generic UI string per_week_short (weekly abbreviation) added for compact time-based metrics display.
Package Metrics & Alternatives
i18n/locales/zh-CN.json
size_decrease object added with parameterised title and description for bundle size reduction tracking. replacement section expanded with native_no_version and related variant keys. likes section extended with ranking tooltip, rank label, and rank link text.
Package README & Version Changes
i18n/locales/zh-CN.json
README section adds error_loading message. Version history section adds license_change_help, license_change_warning, and license_change_record for licence change tracking.
Timeline Feature
i18n/locales/zh-CN.json
New timeline object with load-more and error-state messages, version event type strings (size, dependencies, licences, ESM/CJS, type support, provenance, trusted publishing), chart tab labels, line-chart metric descriptions, and alternative text for copying.
Leaderboard Likes Module
i18n/locales/zh-CN.json
Top-level leaderboard.likes module added with title, description, unavailable state messages, and field labels for likes count display.

Possibly related PRs

  • npmx-dev/npmx.dev#2625: Modifies the same Chinese locale keys including footer sections, shortcuts, package metrics, replacement options, README error handling, and timeline feature.

Suggested reviewers

  • graphieros

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Title check ❌ Error The PR title states 'fix(i18n)' but the objectives document indicates this is a feature addition ('feat(i18n)') that adds missing Chinese locale values—a new functionality rather than a bug fix. Correct the commit type prefix from 'fix' to 'feat' to accurately reflect that this adds new locale translations rather than fixing an existing bug.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the context (48 missing values in zh-CN) and the action taken (updating via pnpm i18n:check:fix command), which relates to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe danielroe changed the title feat(i18n): update zh-CN locale fix(i18n): update zh-CN locale May 11, 2026
@danielroe danielroe added this pull request to the merge queue May 11, 2026
Merged via the queue into npmx-dev:main with commit 14be489 May 11, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants