Skip to content

refactor(i18n): externalize and organize hardcoded strings#282

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:fix/make-words-translatable
Jan 29, 2026
Merged

refactor(i18n): externalize and organize hardcoded strings#282
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:fix/make-words-translatable

Conversation

@shuuji3
Copy link
Copy Markdown
Member

@shuuji3 shuuji3 commented Jan 29, 2026

I found strings and ARIA labels that were hardcoded and not translatable.

This PR replaces hardcoded text and labels in Vue components and adds new keys to en.json.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Jan 29, 2026 8:36am
npmx-lunaria Error Error Jan 29, 2026 8:36am
npmx.dev Ready Ready Preview, Comment Jan 29, 2026 8:36am

Request Review

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

@danielroe danielroe enabled auto-merge January 29, 2026 08:35
@danielroe danielroe disabled auto-merge January 29, 2026 09:18
@danielroe danielroe added this pull request to the merge queue Jan 29, 2026
Merged via the queue into npmx-dev:main with commit e53da33 Jan 29, 2026
12 of 13 checks passed
@shuuji3 shuuji3 deleted the fix/make-words-translatable branch January 29, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants