refactor: convert emoji shortcodes without regex-only parsing

[janewas]

Summary

Addresses #2822 by changing convertToEmoji so it no longer relies on one regex that both finds skipped code/pre blocks and converts emoji shortcodes.

The new implementation scans HTML tokens and emoji shortcodes in order, tracks whether the current position is inside a skipped tag (code/pre), and only converts shortcodes outside those skipped ranges. This keeps code/pre contents untouched while avoiding a single regex that has to match whole code blocks.

Tests

• Added coverage for <pre><code>...</code></pre>
• Added coverage for converting emoji before/after a code block while leaving the code block unchanged
• Locally sanity-checked the conversion logic with Node against the existing and new cases

Closes #2822

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	May 31, 2026 3:47pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	May 31, 2026 3:47pm
npmx-lunaria	Ignored		May 31, 2026 3:47pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 401751b2-629b-4aaf-8905-4dcd8e2b5ba0

📥 Commits

Reviewing files that changed from the base of the PR and between 0981eba and 4048eb0.

📒 Files selected for processing (2)

• shared/utils/emoji.ts
• test/unit/shared/utils/emoji.spec.ts

💤 Files with no reviewable changes (1)

• shared/utils/emoji.ts

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Emoji shortcode conversion now correctly preserves code and pre-formatted regions, avoiding unintended replacements inside code snippets and nested tags.
  • Conversion now respects HTML tag context so shortcodes inside normal text are converted while those within code blocks remain unchanged.

• Tests

  • Added unit tests covering shortcode behaviour inside and outside code/pre blocks.

Walkthrough

Reimplements convertToEmoji to parse HTML with matchAll, track skipDepth for <code>/<pre> to suppress conversions inside them, and convert :shortcode: tokens only outside those tags. Tests added to verify preservation inside code blocks and tag-context-driven conversion.

Changes

Emoji conversion with code block preservation

Layer / File(s)	Summary
Parser implementation and code block skipping shared/utils/emoji.ts	SKIP_EMOJI_TAGS lists code and pre. convertToEmoji now uses a matchAll token scanner, tracks skipDepth for nested <code>/<pre> blocks, incrementally builds output, and replaces :shortcode: tokens only when not inside skipped tags.
Unit tests for code block preservation test/unit/shared/utils/emoji.spec.ts	Adds tests asserting :1234: is unchanged within <pre><code>...</code></pre> and that shortcode conversion occurs outside <code> but is preserved inside <code> segments.

Possibly related PRs

• npmx-dev/npmx.dev#2694: Similar updates to shared/utils/emoji.ts to skip emoji conversion inside <code>/<pre> blocks and related tests.

Suggested reviewers

• shuuji3
• ghostdevv

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: refactoring convertToEmoji to avoid regex-only parsing for handling emoji conversion.
Description check	✅ Passed	The description is directly related to the changeset, explaining the new implementation approach, test coverage, and linking to issue #2822.
Linked Issues check	✅ Passed	The PR successfully addresses #2822 by implementing token-based scanning instead of regex-only parsing, tracking skipDepth for code/pre blocks, and converting emoji only outside skipped regions.
Out of Scope Changes check	✅ Passed	All changes are directly related to the objective: refactoring convertToEmoji implementation and adding test coverage for emoji conversion with code/pre blocks.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Hello! Thank you for opening your first PR to npmx, @janewas! 🚀

Here’s what will happen next:

1. Our GitHub bots will run to check your changes.
   If they spot any issues you will see some error messages on this PR.
   Don’t hesitate to ask any questions if you’re not sure what these mean!

2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

3. One or more of our maintainers will take a look and may ask you to make changes.
   We try to be responsive, but don’t worry if this takes a few days.

[codecov]

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
shared/utils/emoji.ts	79.16%	0 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

[ghostdevv]

That's still regex 😅

[ghostdevv]

I'm fairly certain you're an automated AI agent, and therefore will close this - if I'm wrong please let me know 🙏