You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did a very quick pass of the markup structure and made a few changes that immediately stood out:
Removes unnecssary aria-label for banner/contentinfo landmarks
Removed the label from the body-scoped <header> element. When scoped to the body and not the <main> element or other sectioning content (e.g. <article>, <header>, <footer>, <nav>, <aside>, <section>), a <header> element will implicitly have the role of banner which is a landmark role. According to the ARIA spec for the banner role:
The author SHOULD mark no more than one element on a page with the banner role.
Accessible names are typically used to disambiguate elements with the same role and since there is only one element with this role, then the label is unnecessary.
I should add that it is totally fine to use <header> and <footer> elements within the <main> element like you are.
Removes redundant “navigation” label from navigation landmarks
When assistive technology presents an element with the navigation landmark role (e.g. <nav> elements) it includes the role in the presentation. For example, a screen reader will read “navigation” or, for a labelled landmark, “Main navigation.” So, adding “navigation” to the label is redundant, since a screen reader would read “Main navigation navigation” (and include it that way in its rotor/landmark list).
- There should only be one of each of these per document.
- Any `<header>` or `<footer>` element that’s scoped to the `<main>`
element or sectioning content element will not have the corresponding
landmark role, so you don’t need to stop using them because they do
not cause conflicts with the ones with the implicit landmark roles.
- Thus, the labels are completely unnecessary and not expected.
no worries - just fyi, the merge queue will sync automatically and make sure tests pass when branch is up-to-date, so no need to sync unless there are conflicts
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
knowler
changed the title
I did a very quick pass of the markup structure and made a few changes that immediately stood out:
Removes unnecssary
aria-labelforbanner/contentinfolandmarksRemoved the label from the body-scoped
<header>element. When scoped to the body and not the<main>element or other sectioning content (e.g.<article>,<header>,<footer>,<nav>,<aside>,<section>), a<header>element will implicitly have the role ofbannerwhich is a landmark role. According to the ARIA spec for thebannerrole:Accessible names are typically used to disambiguate elements with the same role and since there is only one element with this role, then the label is unnecessary.
The same applies to the body-scoped
<footer>element which has thecontentinfolandmark role.I should add that it is totally fine to use
<header>and<footer>elements within the<main>element like you are.Removes redundant “navigation” label from navigation landmarks
When assistive technology presents an element with the
navigationlandmark role (e.g.<nav>elements) it includes the role in the presentation. For example, a screen reader will read “navigation” or, for a labelled landmark, “Main navigation.” So, adding “navigation” to the label is redundant, since a screen reader would read “Main navigation navigation” (and include it that way in its rotor/landmark list).