fix: make search cache key a getter so it re-evaluates when the query changes#335
Merged
danielroe merged 2 commits intonpmx-dev:mainfrom Jan 29, 2026
Merged
fix: make search cache key a getter so it re-evaluates when the query changes#335danielroe merged 2 commits intonpmx-dev:mainfrom
danielroe merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
danielroe
approved these changes
Jan 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was trying out the site, I noticed the search results wouldn't change after the first search even if I typed in a new query.
This PR ensures the cache key is recomputed when the query changes by refactoring it from a string to a getter. Admittedly, I'm not very familiar with Vue and simply described the issue to OpenCode with GLM 4.7 while pointing it to the search.vue file.