Skip to content

fix: add missing whitespace before import keyword in code previews#432

Merged
danielroe merged 5 commits intonpmx-dev:mainfrom
mikouaji:fix/missing-whitespace-before-import
Jan 30, 2026
Merged

fix: add missing whitespace before import keyword in code previews#432
danielroe merged 5 commits intonpmx-dev:mainfrom
mikouaji:fix/missing-whitespace-before-import

Conversation

@mikouaji
Copy link
Copy Markdown
Contributor

Fixes issue like those mentioned here

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 30, 2026 8:45pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 30, 2026 8:45pm
npmx-lunaria Ignored Ignored Jan 30, 2026 8:45pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 30, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@garthdw
Copy link
Copy Markdown
Contributor

garthdw commented Jan 30, 2026

Looks like tests might be failing for an unrelated reason?

But this LGTM, ran through a couple packages' code. Couldn't find an await import though.

Do you have an example package?

@mikouaji
Copy link
Copy Markdown
Contributor Author

I've added my own to check a "real" case https://npmx.dev/code/@codeinit/testpackage/v/1.0.0/index.ts

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe
Copy link
Copy Markdown
Member

we should probably also bump the cache key for code

@danielroe danielroe added this pull request to the merge queue Jan 30, 2026
Merged via the queue into npmx-dev:main with commit e690e38 Jan 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants