Skip to content

feat(i18n): improve update process#495

Merged
danielroe merged 3 commits intonpmx-dev:mainfrom
jycouet:feat/improve-i18n-update-process
Jan 31, 2026
Merged

feat(i18n): improve update process#495
danielroe merged 3 commits intonpmx-dev:mainfrom
jycouet:feat/improve-i18n-update-process

Conversation

@jycouet
Copy link
Copy Markdown
Contributor

@jycouet jycouet commented Jan 31, 2026

  • adding a --fix option to the script to simplify the update process (doc updated)
  • update fr doc at the same time

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 31, 2026 1:06pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jan 31, 2026 1:06pm
npmx-lunaria Ignored Ignored Jan 31, 2026 1:06pm

Request Review

@github-actions
Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/fr-FR.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment thread package.json
"dev": "nuxt dev",
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
"i18n:check": "node --experimental-transform-types scripts/compare-translations.ts",
"i18n:check:fix": "node --experimental-transform-types scripts/compare-translations.ts --fix",
Copy link
Copy Markdown
Member

@danielroe danielroe Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should run this in autofix.yml then 🙏

it already automatically strips unused keys, and it would be convenient if it also added new ones. maybe we don't even need the --fix suffix?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, the translated text would be:

"create_account": "EN TEXT TO REPLACE: Create a new account"

To me, this is something you run manually when you want to update translations:

  • Fill in all missing keys
  • Have the English text by default, so you can immediately see what needs to be translated without switching files or hunting for keys

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, makes sense!

@danielroe danielroe added this pull request to the merge queue Jan 31, 2026
Merged via the queue into npmx-dev:main with commit 3acb1be Jan 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants