Conversation
Small change so we don't consider a failure of docs generation to be error level, since _many_ packages fail this (anything using node built ins right now).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
serhalp
approved these changes
Jan 31, 2026
| load: createLoader(), | ||
| resolve: createResolver(), | ||
| }) | ||
| } catch { |
Member
There was a problem hiding this comment.
😰 at some point we should set up Sentry or something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change so we don't consider a failure of docs generation to be
error level, since many packages fail this (anything using node built
ins right now).
edit: @devdumpling before we merge this - im unable to cause the error again locally and can't see the logs for the preview deployment. do you think this change is redundant? my intention was to catch the various WASM errors we were seeing so they don't pollute the logs