fix: replace MarkdownText component with useMarkdown composable #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redictable rendering
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Member
|
maybe a good candidate for some unit tests? |
Contributor
Author
|
Apologies, forgot to update tests. Will do in the morning. |
Contributor
Author
|
Need some more fixes to do |
Member
|
I this one was introduced by 57975af |
Contributor
Author
|
Nah, I just missed the a11y test file still referencing |
Contributor
Author
|
Nothing happened at |
danielroe
approved these changes
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #562
MarkdownTextcomponent processes and shrinks the passed text, so we can't really know if it's empty or not on the outside, which breaks some conditional logic.Since the actual rendering logic is quite simple (dumping html into a span), using a composable instead allows to correctly evaluate if the processed string is empty or now.