Skip to content

refactor: scope css class#605

Merged
serhalp merged 2 commits intonpmx-dev:mainfrom
essenmitsosse:scope-css-class
Feb 1, 2026
Merged

refactor: scope css class#605
serhalp merged 2 commits intonpmx-dev:mainfrom
essenmitsosse:scope-css-class

Conversation

@essenmitsosse
Copy link
Copy Markdown
Contributor

@essenmitsosse essenmitsosse commented Feb 1, 2026

Removes global CSS for skip-link and Readme text and scopes the styles to the component (Readme is extracted to a component).

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 1, 2026 3:39am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 1, 2026 3:39am
npmx-lunaria Ignored Ignored Feb 1, 2026 3:39am

Request Review

Copy link
Copy Markdown
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you!

@serhalp serhalp added this pull request to the merge queue Feb 1, 2026
Merged via the queue into npmx-dev:main with commit 123f321 Feb 1, 2026
14 checks passed
v-html="readmeData.html"
@click="handleClick"
/>
<Readme v-if="readmeData?.html" v-html="readmeData.html" @click="handleClick" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the handle click be moved into the Readme component?

I believe it's for redirecting npm links to npmx. Which would be useful for the code view as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point. Will open a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants