fix: simplify translation sync logic and maintain original order #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
shuuji3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the translation script added new keys at the end of each object, causing key order differences between the original
en.jsonand other locale files. This made it difficult to compare translations side-by-side (I usually do).This PR refactors the sync logic. Instead of constructing a flattened object and applying 'add' and 'remove' operations independently, the new logic traverses the reference object and updates values in-place. This ensures that all locale files strictly maintain the same structure and key order as
en.json.This should not change the current behavior and output text (except reordering) but just to confirm, this is my understanding of the script's behavior:
--fix: only removes extra keys that are not in en.json.--fix: fully synchronizes the locale with en.json (adds missing keys and removes extra ones)