Skip to content

fix(i18n): package count translations#646

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
kuosandys:fix/i18n-package-count
Feb 1, 2026
Merged

fix(i18n): package count translations#646
danielroe merged 2 commits intonpmx-dev:mainfrom
kuosandys:fix/i18n-package-count

Conversation

@kuosandys
Copy link
Copy Markdown
Contributor

Hi there, I was checking out the project (really love the UX btw!) and noticed a few issues with the package count displays:

  • total package count wasn't displayed in pagination view for some languages (e.g. zh-CN)
  • number formatting for packages was inconsistent between package count and pagination controls
  • missing the count argument to enable pluralization

These seemed like small fixes, so I went ahead and fixed them. This is my first contribution to the project, so if there are any additional changes needed or if it's preferred to open an issue first to discuss, I'd be happy to do that.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 1, 2026 1:31pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 1, 2026 1:31pm
npmx-lunaria Ignored Ignored Feb 1, 2026 1:31pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/ar-EG.json Localization changed, will be marked as complete.
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
lunaria/files/fr-FR.json Localization changed, will be marked as complete.
lunaria/files/hu-HU.json Localization changed, will be marked as complete.
lunaria/files/it-IT.json Localization changed, will be marked as complete.
lunaria/files/pl-PL.json Localization changed, will be marked as complete.
lunaria/files/ru-RU.json Localization changed, will be marked as complete.
lunaria/files/uk-UA.json Localization changed, will be marked as complete.
lunaria/files/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@danielroe
Copy link
Copy Markdown
Member

thank you ❤️

@danielroe danielroe added this pull request to the merge queue Feb 1, 2026
Merged via the queue into npmx-dev:main with commit 4e08976 Feb 1, 2026
13 checks passed
taskylizard pushed a commit to taskylizard/npmx.dev that referenced this pull request Feb 7, 2026
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants