-
-
Notifications
You must be signed in to change notification settings - Fork 186
feat: add border to switch styles #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
I personally do not 100% agree with the design of the toggles with those outlines. Another idea to increase the contrast could be to change the background color of a inactive toggle to something lighter (in dark mode) and respectively darker (in light mode). IMO we should keep the little shadow, it creates a nice little effect. But that's just my humble opinion. Great catch! 🙌 |
Good catch this should probably changed so that its border-transparent when checked. |



Dark Before:
Dark After:
Light Before:
Light After:
This is added to improve the contrast. It's still not great but a follow-up can change the actual border colour when in prefers-contrast: more, with this change that's at least some contrast.