fix: correct route query parsing for multiple params#692
Merged
43081j merged 2 commits intonpmx-dev:mainfrom Feb 1, 2026
Merged
fix: correct route query parsing for multiple params#69243081j merged 2 commits intonpmx-dev:mainfrom
43081j merged 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
43081j
approved these changes
Feb 1, 2026
Contributor
43081j
left a comment
43081j
left a comment
There was a problem hiding this comment.
good catch!
the types would've caught this and we casted it away 😅
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many places, there was a force override of types on route.query, and then it worked as if it was a string. But if you pass multiple queries, it would be an array. The result was a 500 error (no trim or no toLowerCase).
I added a common method and use it everywhere. The method returns the value, either the first element of the array, or an empty string
Closes #688