fix: layout shift during code nav from root to any file/dir#75
Merged
danielroe merged 2 commits intonpmx-dev:mainfrom Jan 25, 2026
Merged
Conversation
|
@devdumpling is attempting to deploy a commit to the danielroe Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
PSA this is the first vue i've like basically ever written. |
devdumpling
commented
Jan 25, 2026
Comment on lines
+346
to
+352
| v-if="filePath" | ||
| :to="getCodeUrl()" | ||
| class="text-fg-muted hover:text-fg transition-colors shrink-0" | ||
| > | ||
| root | ||
| </NuxtLink> | ||
| <span v-else class="text-fg shrink-0">root</span> |
Contributor
Author
There was a problem hiding this comment.
Idea here was to only have the link outside of the root, but can simplify if this is overly complex for breadcrumb linkage.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danielroe
approved these changes
Jan 25, 2026
vinnymac
pushed a commit
to vinnymac/npmx.dev
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Simple layout shift fix for breadcrumbs. Slightly less visual pleasing for root, but stabilizes. If we'd prefer, we could space it instead but I think the
rootbreadcrumb is consistent. Just my 2c.Screen.Recording.2026-01-25.at.11.13.09.AM.mov