-
-
Notifications
You must be signed in to change notification settings - Fork 180
feat(org): embed search scope as operator in url #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Search scope is now part of the q= param using operator syntax like ?q=description:core instead of separate scope= param in preparation for multi-scope search; currently left in single-scope mode
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
https://npmx-my2gci1n9-poetry.vercel.app/@vueuse is a good test case |
📝 WalkthroughWalkthroughThis change refactors the search functionality within the organisation page component. It introduces a helper function to construct search queries from text, scope, and keywords components. The implementation adds query parsing logic to establish an initial search scope, extends type imports to include 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Search scope is now part of the
q=paramusing operator syntax like?q=description:coreinstead of separatescope= paramin preparation for multi-scope search; currently left in single-scope mode. To keep the scope of this PR small, I wired the filter params to be active 1 at a time as multi scope search requires a bigger UI overhaul.buildSearchQueryexists solely for ease of enabling multi args search in the future.I decided against short keywords in the URL for now, although could adopt
kw,descetc.Closes #761