chore: fix navigation to home

[iiio2]

This is for the mobile version.

In the Navbar we get logo + search icon in any page like "/about", "/compare" etc. When we click on the search icon it expands a searchbar. Currently when we click on the logo, it also expands a searchbar. I mean I think when we click on logo we should navigate to "/" page. In the desktop version, when we click on the logo, it navigates to "/" page.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview, Comment	Feb 12, 2026 4:46pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Feb 12, 2026 4:46pm
npmx-lunaria	Ignored		Feb 12, 2026 4:46pm

[danielroe]

it's intentional, to reduce clicks when searching.

what we could do is add an additional search button in the header, that expands into the search bar when clicked. it could be located next to the mobile menu button on the right

[iiio2]

@danielroe , I think I've done it now.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[coderabbitai]

📝 Walkthrough

Walkthrough

The AppHeader.vue component has been refactored to improve mobile navigation handling. The mobile logo element was converted from a non-functional button to a NuxtLink for home navigation with updated accessibility labels. The inline search icon was removed from the logo area. A new mobile search trigger button (ButtonBase) was introduced, appearing conditionally when not on the home page and when search is not expanded. The desktop layout structure remains unchanged, though the logo section now consistently uses NuxtLink for navigation. Minor CSS class adjustments were made to the nav container.

Possibly related PRs

• fix: redundant mobile menu close logic #992: Modifies mobile header controls and accessibility attributes in AppHeader.vue

Suggested labels

front

Suggested reviewers

• danielroe
• serhalp

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly relates to the changeset, describing the mobile navbar logo navigation issue and the expected fix.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

app/components/AppHeader.vue (1)

276-284: Consider placing v-if before other attributes for consistency.

Vue style guides typically recommend placing directives like v-if near the top of the attribute list for better readability. This is a minor style suggestion.

♻️ Suggested reordering

       <ButtonBase
+        v-if="!isSearchExpanded && !isOnHomePage"
         type="button"
         class="sm:hidden ms-auto"
         :aria-label="$t('nav.tap_to_search')"
         :aria-expanded="isSearchExpanded"
         `@click`="expandMobileSearch"
-        v-if="!isSearchExpanded && !isOnHomePage"
         classicon="i-carbon:search"
       />

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Incorrect aria-expanded binding on mobile search button.

The aria-expanded attribute is bound to showMobileMenu, but this button controls search expansion, not the mobile menu. Screen readers will announce the wrong state.

🐛 Proposed fix

       <ButtonBase
         type="button"
         class="sm:hidden ms-auto"
         :aria-label="$t('nav.tap_to_search')"
-        :aria-expanded="showMobileMenu"
+        :aria-expanded="isSearchExpanded"
         `@click`="expandMobileSearch"
         v-if="!isSearchExpanded && !isOnHomePage"
         classicon="i-carbon:search"
       />

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	<!-- Mobile: Search button (expands search) -->
	<ButtonBase
	type="button"
	class="sm:hidden ms-auto"
	:aria-label="$t('nav.tap_to_search')"
	:aria-expanded="showMobileMenu"
	@click="expandMobileSearch"
	v-if="!isSearchExpanded && !isOnHomePage"
	classicon="i-carbon:search"
	/>
	<!-- Mobile: Search button (expands search) -->
	<ButtonBase
	type="button"
	class="sm:hidden ms-auto"
	:aria-label="$t('nav.tap_to_search')"
	:aria-expanded="isSearchExpanded"
	`@click`="expandMobileSearch"
	v-if="!isSearchExpanded && !isOnHomePage"
	classicon="i-carbon:search"
	/>

[iiio2]

Thanks @danielroe , @ghostdevv .