Skip to content

chore: clean up deps & add comments to knip#849

Merged
danielroe merged 6 commits intonpmx-dev:mainfrom
essenmitsosse:remove-unnecessary-dependency
Feb 3, 2026
Merged

chore: clean up deps & add comments to knip#849
danielroe merged 6 commits intonpmx-dev:mainfrom
essenmitsosse:remove-unnecessary-dependency

Conversation

@essenmitsosse
Copy link
Contributor

@essenmitsosse essenmitsosse commented Feb 3, 2026

  • Convert knip config to .ts — so comments can be added
  • Clean up dependencies

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Error Error Feb 3, 2026 4:32pm
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 4:32pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 3, 2026 4:32pm

Request Review

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@essenmitsosse essenmitsosse force-pushed the remove-unnecessary-dependency branch from f5ade63 to 5b87807 Compare February 3, 2026 16:12
@essenmitsosse essenmitsosse changed the title chore: clean up deps & speed up ci chore: clean up deps & run knip in strict mode Feb 3, 2026
@essenmitsosse essenmitsosse force-pushed the remove-unnecessary-dependency branch from 7337091 to 4bd50a2 Compare February 3, 2026 16:30
@essenmitsosse essenmitsosse changed the title chore: clean up deps & run knip in strict mode chore: clean up deps Feb 3, 2026
@essenmitsosse essenmitsosse changed the title chore: clean up deps chore: clean up deps & add comments to knip Feb 3, 2026
@essenmitsosse essenmitsosse marked this pull request as ready for review February 3, 2026 16:41
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The pull request replaces the knip.json configuration file with a knip.ts TypeScript configuration file, maintaining the same workspace and dependency definitions but in a different format. Additionally, a JSDoc parameter type annotation is removed from the lighthouse-setup.cjs file without changing the function signature. In package.json, the dependency "@intlify/core-base" is relocated from dependencies to devDependencies, whilst "fast-npm-meta" is moved from devDependencies to dependencies.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset: converting knip config to TypeScript and cleaning up dependencies.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into npmx-dev:main with commit 07ce0e4 Feb 3, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants