Skip to content

Conversation

@rshigg
Copy link
Contributor

@rshigg rshigg commented Jan 25, 2026

Summary

Adds automated Lighthouse accessibility testing on PR push/merge. For now it will only produce warnings.

If we want to see the LH job status in the PRs, we would need the Lighthouse CI Github app installed: https://github.com/apps/lighthouse-ci

Changes

  • Create lighthouse ci config
  • Add CI job that sets up pnpm, builds the app, then runs lhci

@vercel
Copy link

vercel bot commented Jan 25, 2026

@rshigg is attempting to deploy a commit to the danielroe Team on Vercel.

A member of the Team first needs to authorize it.

@rshigg rshigg changed the title feat: add lighthouse accessibility testing job to CI Add lighthouse accessibility testing job to CI Jan 25, 2026
@vercel
Copy link

vercel bot commented Jan 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 25, 2026 8:58pm

Request Review

@danielroe
Copy link
Member

danielroe commented Jan 25, 2026

I've now installed the LH GH app - so we probably can use the action without needing to install the cli within the project

@rshigg
Copy link
Contributor Author

rshigg commented Jan 25, 2026

I've now installed the LH GH app - so we probably can use the action without needing to install the cli within the project

Thank you! The only reason I can think of to install the CLI now is if someone wants to create a report locally. But you can always use npx @lhci/cli in that case. I'll remove the dep

@danielroe danielroe merged commit b960d06 into npmx-dev:main Jan 25, 2026
7 checks passed
vinnymac pushed a commit to vinnymac/npmx.dev that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants