Skip to content

Conversation

@sybers
Copy link
Contributor

@sybers sybers commented Feb 3, 2026

Some icons were not using tooltips but an html title attr instead, it was the case for the "install size (i)" and the "create new project (i)".

This PR fixes these two tooltips !

Here are a few screenshots (in French 🥖)

CleanShot 2026-02-03 at 22 09 26@2x CleanShot 2026-02-03 at 22 11 44@2x

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Error Error Feb 3, 2026 10:16pm
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 10:16pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Feb 3, 2026 10:16pm

Request Review

@sybers sybers changed the title fix(client): add missing AppTooltip usages fix(ui): add missing AppTooltip usages Feb 3, 2026
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/components/Terminal/Install.vue 0.00% 1 Missing and 1 partial ⚠️
app/pages/package/[...package].vue 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Replaces inline title attributes on information icons with a TooltipApp wrapper in multiple components (app/components/Terminal/Install.vue and app/pages/package/[...package].vue), changing how tooltip text is rendered while keeping the same SR-only content. Updates the tooltip base component (app/components/Tooltip/Base.vue) CSS class from whitespace-nowrap to whitespace-pre-line to allow line wrapping and preserve line breaks. No changes to exported/public APIs or underlying data.

Suggested reviewers

  • knowler
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description accurately describes the changeset: replacing HTML title attributes with AppTooltip components for two icons ('install size' and 'create new project'), with supporting screenshots.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

@sybers
Copy link
Contributor Author

sybers commented Feb 3, 2026

Not sure what I should do with the coverage issue here, is there a test that needs to be added/updated ?

@danielroe danielroe enabled auto-merge February 3, 2026 22:15
@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into npmx-dev:main with commit 3185c40 Feb 3, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants