Skip to content

feat: link package headers to package pages#911

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:feat/allow-navigate-to-package-page-from-comparison
Feb 4, 2026
Merged

feat: link package headers to package pages#911
danielroe merged 2 commits intonpmx-dev:mainfrom
shuuji3:feat/allow-navigate-to-package-page-from-comparison

Conversation

@shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 4, 2026

User story

When user want to find a good package and compared multiple packages and want to look into a specific package, the user has to type the same package names in the search input again.

Solution

This PR allows to navigate directly from each header of the comparison table.

Deploy preview

https://npmxdev-git-fork-shuuji3-feat-allow-navigate-to-p-54f516-poetry.vercel.app/compare?packages=vue,nuxt,vite

Screenshot

Screenshot of comparison page, the header is now clickable link

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 8:40am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 8:40am
npmx-lunaria Ignored Ignored Feb 4, 2026 8:40am

Request Review

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

A change to the ComparisonGrid component modifies header cells by replacing non-interactive text spans with NuxtLink components. The header cells now navigate to /package/{header} when clicked. Styling and title attributes are retained from the original implementation. The layout and other component behaviour remain unchanged. No public API changes are involved.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the user story, solution, and providing a screenshot showing the implementation of clickable package headers in the comparison table.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit a29b6e3 Feb 4, 2026
17 checks passed
@shuuji3 shuuji3 deleted the feat/allow-navigate-to-package-page-from-comparison branch February 4, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants