Skip to content

Conversation

@IHIutch
Copy link
Contributor

@IHIutch IHIutch commented Jan 26, 2026

Adds weekly downloads to Package card. Since you can sort by downloads, its useful feedback to see the download counts

Makes a few additional changes:

  • Uses a "stretched link" to make the whole card clickable rather than wrapping full card contents in the anchor tag
  • Adds a focus state to PackageCard
  • Adjusts card layout to account for the addition of weekly downloads
  • This layout breaks the header/footer structure, which I dont think are necessary, replacing them with divs to avoid confusing the semantic structure
Package list view showing updated card layout, including number of weekly downloads

@vercel
Copy link

vercel bot commented Jan 26, 2026

@IHIutch is attempting to deploy a commit to the danielroe Team on Vercel.

A member of the Team first needs to authorize it.

@IHIutch IHIutch marked this pull request as ready for review January 26, 2026 02:57
@IHIutch
Copy link
Contributor Author

IHIutch commented Jan 26, 2026

Im not 100% sure on the layout, would love feedback

One important note: ProvenanceBadge includes a link element, which I think is technically accessible since the link isn't semantically nested, but still feels a bit weird because it appears nested because of the stretched link on the card

Screen shot of the Provenance Badge link appearing inside the package card link

@danielroe
Copy link
Member

we should probably disable that as a link and make it purely visual.

might need to pass a prop down

@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 26, 2026 2:08pm

Request Review

@danielroe danielroe merged commit cda7f6e into npmx-dev:main Jan 26, 2026
8 checks passed
vinnymac pushed a commit to vinnymac/npmx.dev that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants