Skip to content

style: improve background color for overflowed in Select#988

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
rzzf:style/download-analytics-granularity-bgc
Feb 5, 2026
Merged

style: improve background color for overflowed in Select#988
danielroe merged 2 commits intonpmx-dev:mainfrom
rzzf:style/download-analytics-granularity-bgc

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Feb 5, 2026

Before After
image image

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 7:55am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 7:55am
npmx-lunaria Ignored Ignored Feb 5, 2026 7:55am

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Added the overflow-hidden class to the wrapper div around the granularity select in the DownloadAnalytics Vue component. This is a single-line styling change that affects only the component's layout/visual presentation; no logic, data flow, or functional behaviour was modified.

Suggested reviewers

  • serhalp
  • 43081j
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The PR description provides a before/after visual comparison directly related to the styling changes made to the DownloadAnalytics.vue component.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroe
Copy link
Member

I think this bg might have been addressing an issue rendering on Linux

@danielroe danielroe enabled auto-merge February 5, 2026 07:54
@rzzf
Copy link
Contributor Author

rzzf commented Feb 5, 2026

Thanks for the review. Since I don’t have a Linux environment, I wasn’t able to test it, so I switched to an alternative implementation.

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit d7bb811 Feb 5, 2026
16 checks passed
@rzzf rzzf deleted the style/download-analytics-granularity-bgc branch February 5, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants