Skip to content

fix: improve a11y for search results#990

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/search-result-a11y
Feb 5, 2026
Merged

fix: improve a11y for search results#990
danielroe merged 1 commit intonpmx-dev:mainfrom
rzzf:fix/search-result-a11y

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Feb 5, 2026

Bug Reproduction: When you navigate to the tag button using the Tab key and press ArrowUp or ArrowDown, the focus jumps back to the first result instead of the previous one.

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 5, 2026 5:59am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 5, 2026 5:59am
npmx-lunaria Ignored Ignored Feb 5, 2026 5:59am

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

A data attribute binding is added to the TagButton element within the keywords list in the Card component. The new binding, :data-result-index="index", passes the current index value as a data attribute to enable result indexing. The existing click handling, keyword rendering logic, and component structure remain unchanged.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes a bug related to focus navigation with arrow keys on tag buttons, which aligns with the changeset that adds a data-result-index attribute to support accessibility improvements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 5, 2026
Merged via the queue into npmx-dev:main with commit 6f653e2 Feb 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants