Skip to content

Conversation

@nordic-segl
Copy link
Contributor

Bring in additional CAN tests.

manifest-pr-skip

@nordic-segl nordic-segl force-pushed the NRFX-6088_Extend_CAN_API_test branch from 630a636 to f866ddd Compare October 24, 2024 05:58
@gmarull
Copy link
Member

gmarull commented Oct 24, 2024

do we need that immediately, or can this wait until next upmerge?

@nordic-segl
Copy link
Contributor Author

do we need that immediately, or can this wait until next upmerge?

It can wait.
"until next upmerge" - You mean to close this PR and wait for upmerge to bring this changes in?

@gmarull
Copy link
Member

gmarull commented Oct 24, 2024

do we need that immediately, or can this wait until next upmerge?

It can wait. "until next upmerge" - You mean to close this PR and wait for upmerge to bring this changes in?

yes

…d_rx_filter()

Check that error is reported when CAN filter is added without
callback function.

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
(cherry picked from commit dbc8eaa)
…t_bitrate()

There is negative test for too high bitrate.
Add test that checks too low bitrate.

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
(cherry picked from commit 13fbac8)
…t_bitrate_data()

There is negative test for too high data bitrate.
Add test that checks too low data bitrate.

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
(cherry picked from commit 2616720)
…nd()

Check error codes when sending invalid frames:
- too big data payload;
- wrong set of flags.

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
(cherry picked from commit 8023a58)
@nordic-segl nordic-segl force-pushed the NRFX-6088_Extend_CAN_API_test branch from f866ddd to dbfa14f Compare October 29, 2024 07:28
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Oct 29, 2024
Bring in additional CAN tests:
nrfconnect/sdk-zephyr#2151
zephyrproject-rtos/zephyr#80063

Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
@rlubos rlubos merged commit 6893450 into nrfconnect:main Oct 30, 2024
15 checks passed
@nordic-segl nordic-segl deleted the NRFX-6088_Extend_CAN_API_test branch October 30, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants