nx release --dry-run fails if a version plan is present

[Saadnajmi]

Current Behavior

We added nx release --dry-run as a PR check for our repo. If the PR contains a version plan, dry run fails at the step of trying to create a Github release.

Expected Behavior

Dry Run shouldn't fail

GitHub Repo

No response

Steps to Reproduce

Nx Report

sanajmi@Saads-MacBook-Pro-14 react-native-macos % yarn nx report

 NX   Report complete - copy this into the issue template

Node           : 23.6.1
OS             : darwin-arm64
Native Target  : aarch64-macos
yarn           : 4.5.1

nx             : 20.0.7
@nx/js         : 20.0.7
@nx/workspace  : 20.0.7
@nx/devkit     : 20.0.7
typescript     : 5.0.4
---------------------------------------
Local workspace plugins:
         @react-native-mac/nx-release-version

sanajmi@Saads-MacBook-Pro-14 react-native-macos %

Failure Logs

...
Would push the current branch to the remote with the following command, but --dry-run was set:
git push --follow-tags --no-verify --atomic

 NX   Creating GitHub Release


 NX   Request failed with status code 403

AxiosError: Request failed with status code 403
    at settle (/Users/runner/work/1/s/node_modules/axios/dist/node/axios.cjs:2031:12)
    at IncomingMessage.handleStreamEnd (/Users/runner/work/1/s/node_modules/axios/dist/node/axios.cjs:3148:11)
    at IncomingMessage.emit (node:events:536:35)
    at endReadableNT (node:internal/streams/readable:1698:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
    at Axios.request (/Users/runner/work/1/s/node_modules/axios/dist/node/axios.cjs:4258:41)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async makeGithubRequest (/Users/runner/work/1/s/node_modules/nx/src/command-line/release/utils/github.js:272:13)
    at async getGithubReleaseByTag (/Users/runner/work/1/s/node_modules/nx/src/command-line/release/utils/github.js:269:12)
    at async createOrUpdateGithubRelease (/Users/runner/work/1/s/node_modules/nx/src/command-line/release/utils/github.js:75:43)
    at async release (/Users/runner/work/1/s/node_modules/nx/src/command-line/release/release.js:202:21)
    at async handleErrors (/Users/runner/work/1/s/node_modules/nx/src/utils/handle-errors.js:9:24)
    at async Object.handler (/Users/runner/work/1/s/node_modules/nx/src/command-line/release/command-object.js:98:24)

Package Manager Version

yarn 4.5.0

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[Saadnajmi]

Hmm, this seems to be intermittent

[Saadnajmi]

Nevermind, it was pretty stably happening across a brunch of branches for me again :(

[Saadnajmi]

OK, I figured out the issue. The dry run, when a change file, needs a GITHUB_TOKEN in order to read the Github releases in prep for making a new one, even on the dry run. In our CI, we explicitly don't give the dry run a Github or NPM token.

Feel free to close this as "by design" if that makes more sense :)

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.