Skip to content

Comments

fix(release): properly handle deeply-transitive updates#30325

Closed
simon-abbott wants to merge 1 commit intonrwl:masterfrom
simon-abbott:fix-release-transitive-deps
Closed

fix(release): properly handle deeply-transitive updates#30325
simon-abbott wants to merge 1 commit intonrwl:masterfrom
simon-abbott:fix-release-transitive-deps

Conversation

@simon-abbott
Copy link

Current Behavior

Using nx release to update a package that has recursively-transitive dependencies (i.e. pkg-a -> pkg-b -> pkg-c -> pkg-d) fails to properly update the full version tree, resulting in failures.

Expected Behavior

The versions should all be updated properly, even if they are far away in the dependency graph.

Related Issue(s)

Fixes #29375

@simon-abbott simon-abbott requested a review from a team as a code owner March 10, 2025 23:47
@simon-abbott simon-abbott requested a review from Coly010 March 10, 2025 23:47
@vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 0:02am

@JamesHenry
Copy link
Collaborator

Hi @simon-abbott, I'm sorry for the delay on this one, as you might have seen it's down to the fact that the implementation of versioning has been totally rewritten to be more powerful and flexible. The legacy implementation can be considered frozen, and this should not be an issue on the new implementation.

The new one landed as opt-in in 20.8, you can set release.version.useLegacyVersionsing: false in your nx.json in that version and later, or in 21 it becomes the default, and there is an automated migration for existing workspaces, so you can also just wait until tomorrow when nx 21.0.0 should hopefully drop.

Cheers!

@JamesHenry JamesHenry closed this May 1, 2025
@simon-abbott simon-abbott deleted the fix-release-transitive-deps branch May 6, 2025 15:41
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nx release command is not bumping all the dependents chain

2 participants