Skip to content

Comments

chore(repo): fix assignment rules to prevent early termination#30382

Merged
jaysoo merged 2 commits intomasterfrom
lourw/early-termination
Apr 2, 2025
Merged

chore(repo): fix assignment rules to prevent early termination#30382
jaysoo merged 2 commits intomasterfrom
lourw/early-termination

Conversation

@lourw
Copy link
Contributor

@lourw lourw commented Mar 14, 2025

Current Behavior

We set assignment rules to default all tasks to medium, which meant that after the linux-large agent was complete, it would terminate since no tasks would be assigned to it. This fixes the rules to ensure that tasks can also be assigned to the linux-large agent.

Expected Behavior

Related Issue(s)

Fixes #

@lourw lourw requested a review from a team as a code owner March 14, 2025 17:20
@lourw lourw requested a review from Cammisuli March 14, 2025 17:20
@lourw lourw self-assigned this Mar 14, 2025
@vercel
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 2, 2025 4:09pm

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 14, 2025

View your CI Pipeline Execution ↗ for commit afe8836.

Command Status Duration Result
nx run-many -t check-imports check-commit check... ✅ Succeeded 12s View ↗
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded <1s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=9a7a4... ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 16:07:04 UTC

@lourw lourw changed the title chore(repo): fix stop agents after to prevent early termination chore(repo): fix assignment rules to prevent early termination Mar 14, 2025
@lourw lourw enabled auto-merge (squash) March 14, 2025 18:33
@lourw lourw force-pushed the lourw/early-termination branch from 82d5bc8 to e58f0a0 Compare March 14, 2025 18:33
@lourw lourw force-pushed the lourw/early-termination branch from e58f0a0 to 371cb44 Compare April 2, 2025 14:31
@jaysoo jaysoo disabled auto-merge April 2, 2025 16:27
@jaysoo jaysoo merged commit fd337bb into master Apr 2, 2025
12 checks passed
@jaysoo jaysoo deleted the lourw/early-termination branch April 2, 2025 16:27
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants