Skip to content

chore(repo): update gh actions version #30561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meeroslav merged 1 commit into from
Apr 10, 2025
Merged

chore(repo): update gh actions version #30561

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
filter: tree:0

- name: Fetch Master
run: git fetch origin master:master
if: ${{ github.event_name == 'pull_request' }}


- name: Set SHAs
uses: nrwl/nx-set-shas@v4
with:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
run: |
pids=()

pnpm nx-cloud record -- nx format:check --base=$NX_BASE --head=$NX_HEAD &
pnpm nx-cloud record -- nx format:check &
pids+=($!)

pnpm nx-cloud record -- nx sync:check
Expand All @@ -85,7 +85,7 @@ jobs:
pnpm nx run-many -t check-imports check-commit check-lock-files check-codeowners --parallel=1 --no-dte &
pids+=($!)

pnpm nx affected --targets=lint,test,build,e2e,e2e-ci --base=$NX_BASE --head=$NX_HEAD &
pnpm nx affected --targets=lint,test,build,e2e,e2e-ci &
Copy link

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the '--base' and '--head' parameters in the affected command could alter its behavior. Please verify that this modification is aligned with the intended CI logic.

Suggested change
pnpm nx affected --targets=lint,test,build,e2e,e2e-ci &
pnpm nx affected --targets=lint,test,build,e2e,e2e-ci --base=$BASE_SHA --head=$HEAD_SHA &

Copilot uses AI. Check for mistakes.
pids+=($!)

for pid in "${pids[@]}"; do
Expand All @@ -102,16 +102,17 @@ jobs:
SELECTED_PM: 'npm'
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
filter: tree:0

- name: Fetch Master
run: git fetch origin master:master
if: ${{ github.event_name == 'pull_request' }}

- name: Restore Homebrew packages
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
/usr/local/Homebrew
Expand All @@ -126,7 +127,7 @@ jobs:
timeout-minutes: 20

- name: Save Homebrew Cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: |
/usr/local/Homebrew
Expand All @@ -151,7 +152,7 @@ jobs:
uses: nrwl/nx-set-shas@v4
with:
main-branch-name: 'master'

- name: Run E2E Tests for macOS
run: |
HAS_CHANGED=$(node ./scripts/check-react-native-changes.js $NX_BASE $NX_HEAD);
Expand Down