fix(module-federation): enable ESM output for Angular rspack MF plugin#34839
Merged
FrozenPandaz merged 2 commits intomasterfrom Mar 20, 2026
Merged
fix(module-federation): enable ESM output for Angular rspack MF plugin#34839FrozenPandaz merged 2 commits intomasterfrom
FrozenPandaz merged 2 commits intomasterfrom
Conversation
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit cd67302
☁️ Nx Cloud last updated this comment at |
…M output Adds a browser-level test that navigates to the remote route to verify remoteEntry.js loads correctly. This catches ESM runtime errors like "Unexpected token 'export'" that only surface in the browser.
FrozenPandaz
force-pushed
the
fix/34584-angular-rspack-mf-esm
branch
from
6168031 to
cd67302
Compare
jaysoo
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using Angular + Rspack + Module Federation, the
NxModuleFederationPlugin(Angular variant) setslibrary: { type: 'module' }on the Module Federation plugin config, which causesremoteEntry.jsto emit ESMexportstatements. However, the compiler'sexperiments.outputModuleandoutput.moduleflags are not set, so the MF runtime tries to load the remote entry as a classic script. This results in:This is especially broken during
nx serve(dev server), because@nx/angular-rspack'screateConfigonly setsexperiments.outputModule = truefor production builds, not dev server builds.Expected Behavior
The Angular rspack
NxModuleFederationPluginshould ensureexperiments.outputModule = trueandoutput.module = trueare set on the compiler when usinglibrary: { type: 'module' }, so that Module Federation works out of the box in both dev and production modes.This aligns with how the Angular webpack MF config already handles it (in
with-module-federation/angular/with-module-federation.ts).Related Issue(s)
Fixes #34584
Fixes #33992