-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor CLI to use Typer instead of argparse. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MOBergeron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je me demande si la version que j'ai fait, on pourrait le transformer avec ça. https://typer.tiangolo.com/tutorial/options/version/
Ça semble pouvoir quitter le programme plus rapidement sans tout charger.
Aussi, puisque maintenant on fait un ctf init dans le workflow, le dossier .deploy semble être inutile dans le root du répository, est-ce qu'on l'enlève?
| import textwrap | ||
| from datetime import datetime | ||
| from enum import Enum, unique | ||
| from enum import StrEnum, unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.python.org/3/library/enum.html#enum.StrEnum
Added in version 3.11.
Notre pyproject.toml dit 3.10 minimum. C'est la raison pourquoi j'avais revert back le StrEnum in the first place. Est-ce qu'on veut bump la version minimum de python? Ou est-ce qu'on revert this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je bumperais perso
Oui on peut enlever .deploy et oui on peut utiliser le —version jpeux m'en occuper plus tard |
Dans un autre PR ou dans celui-ci? |
|
Dans cette pr |
In a future PR I'll split each command in a separate file.