Fix arcane-deploy: timeout, API parsing, and repo enabled state#15
Merged
Fix arcane-deploy: timeout, API parsing, and repo enabled state#15
Conversation
The Arcane API wraps all responses in {success, data, pagination} but
the action was parsing responses as raw arrays/objects. This caused
repository lookup to always miss (creating duplicates) and ID extraction
from create responses to fail.
- List endpoints: use .data[] instead of .[] to iterate items
- Create endpoints: use .data.id instead of .id to extract IDs
https://claude.ai/code/session_01EPuZkcSGc4zpbDDBvMd3Jz
The Arcane server performs an initial git sync inline during POST /gitops-syncs (cloning the repo and deploying the compose file). The server-side timeout for this is 5 minutes, but the curl --max-time was only 30 seconds, causing the request to time out before the sync could complete. https://claude.ai/code/session_01EPuZkcSGc4zpbDDBvMd3Jz
When updating an existing repository's credentials, the action was not setting enabled: true. If the repo was disabled in Arcane, it would stay disabled and syncs would not work. https://claude.ai/code/session_01EPuZkcSGc4zpbDDBvMd3Jz
nsheaps
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-timefrom 30s to 360s — the Arcane server performs an initial git sync inline duringPOST /gitops-syncs(server timeout is 5 min), so the 30s client timeout was killing the request before the sync could completeenabled: truein the repository update payload — without this, if the repo was disabled in Arcane, the action would update credentials but leave it disabled, preventing syncs from workingTest plan
https://claude.ai/code/session_01EPuZkcSGc4zpbDDBvMd3Jz