Skip to content

Define guidelines for labels management#6

Merged
damienfraud merged 12 commits intomasterfrom
define-label-guidelines
May 30, 2018
Merged

Define guidelines for labels management#6
damienfraud merged 12 commits intomasterfrom
define-label-guidelines

Conversation

@damienfraud
Copy link
Copy Markdown
Contributor

@damienfraud damienfraud commented May 23, 2018

Goals ⚽

Define GitHub guidelines in terms of labels use and management.

Inspiration 💡

@damienfraud damienfraud self-assigned this May 23, 2018
@damienfraud damienfraud requested a review from romsi May 23, 2018 15:00
@romsi romsi changed the title Define guidelines for labels management. Define guidelines for labels management May 23, 2018
Copy link
Copy Markdown
Contributor

@romsi romsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damienfraud we should have 2 more headlines (Immutability and Color). Use the pattern Preferred/Not Preferred to describe these sections.

Comment thread README.md Outdated

## Label

We believe GitHub labels should define immutable informations about issues.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use we or you to describe the guideline.

Comment thread README.md Outdated

We believe GitHub labels should define immutable informations about issues.

We consider having to change labels over time to be a bad practice. Indeed, changing labels manually multiple times on issues can be very time consumming and prone to errors. Moreover, we believe that if the information about the issue is changing, it is surely not a relevant information to have as a label. Almost everytime, you will see that variable informations about an issue can be managed in another way which will be much more efficient in the end. If you consider this, you will tremendously reduce useless labels creation, and see that you have more than enough information through it.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use we or you to describe the guideline.

Comment thread README.md Outdated

We consider having to change labels over time to be a bad practice. Indeed, changing labels manually multiple times on issues can be very time consumming and prone to errors. Moreover, we believe that if the information about the issue is changing, it is surely not a relevant information to have as a label. Almost everytime, you will see that variable informations about an issue can be managed in another way which will be much more efficient in the end. If you consider this, you will tremendously reduce useless labels creation, and see that you have more than enough information through it.

We believe that labels should be regrouped into categories and that you only need three of them. We also recommend to use similar color styling accross categories for a stronger visual identification.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use we or you to describe the guideline.

@damienfraud
Copy link
Copy Markdown
Contributor Author

@romsi I added Immutabilty and Colors headlines, using Why pattern. I also removed we and you from guidelines.

@romsi
Copy link
Copy Markdown
Contributor

romsi commented May 28, 2018

@damienfraud I updated the milestone section. We should find a pattern that is visual in order to quickly get the important information. Text is good, but visual should be our guideline.

@damienfraud
Copy link
Copy Markdown
Contributor Author

@romsi I updated the guidelines with a new formatting suggestion.
I added the Why section again to make descriptions more concise.
Also, I found the Preferred/Not Preferred format not optimal in this case. I suggest a Format with expendables examples instead, which still gives quick visual idea of the section without overloading the page with too many examples.
Finally, I really liked the use you have for Pro Tip section. 👍

@romsi
Copy link
Copy Markdown
Contributor

romsi commented May 28, 2018

@damienfraud we agreed on a new format. You need to fulfil the resources section and then we can merge it.

damienfraud and others added 4 commits May 28, 2018 18:56
- Add introduction for label section.
- Fix typos.
- Rearrange content for type of change section.
@romsi
Copy link
Copy Markdown
Contributor

romsi commented May 30, 2018

@damienfraud Please check my 2 latest commit. We should use the full title for links instead of using the source only.

Preferred

@romsi
Copy link
Copy Markdown
Contributor

romsi commented May 30, 2018

@damienfraud please check my latest commits. We should use the full title for links instead of the source name at the end.

Preferred

- [A better collaboration using Github](https://github.com/blog/a-better-collaboration).

Not Preferred

- A better collaboration using Github. [Github](https://github.com/blog/a-better-collaboration).

Imagine you are blind and you only get the information inside the brackets. Try to figure out what is the context and where are you going to end up using this link.

@damienfraud
Copy link
Copy Markdown
Contributor Author

@romsi I'm ok with your changes. I will merge the PR.

@damienfraud damienfraud merged commit 3ef92f0 into master May 30, 2018
@damienfraud damienfraud deleted the define-label-guidelines branch May 30, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants