Skip to content

Double32 format support in progress#43

Merged
nsmith- merged 11 commits intonsmith-:mainfrom
dbizdfvy:double32-support
Jul 14, 2025
Merged

Double32 format support in progress#43
nsmith- merged 11 commits intonsmith-:mainfrom
dbizdfvy:double32-support

Conversation

@dbizdfvy
Copy link
Collaborator

No description provided.

Copy link
Owner

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks very good!
Can you run nox -s lint and let it fix the formatting issues to ensure the linter is happy?
I see that the _FixedSizeArrayReader will still need an implementation that calls into Double32Serde. Perhaps we can make that a later project.

@dbizdfvy dbizdfvy marked this pull request as ready for review July 9, 2025 16:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 87.09677% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.83%. Comparing base (a7f106b) to head (1d6213f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/rootfilespec/bootstrap/double32.py 83.67% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.75%   90.83%   +0.07%     
==========================================
  Files          33       34       +1     
  Lines        2412     2476      +64     
==========================================
+ Hits         2189     2249      +60     
- Misses        223      227       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@nsmith- nsmith- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsmith- nsmith- merged commit 9f677ea into nsmith-:main Jul 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants