Skip to content

.golangci.yml: enable modernize linter#45

Open
AnnaShaleva wants to merge 1 commit intomasterfrom
enable-modernize
Open

.golangci.yml: enable modernize linter#45
AnnaShaleva wants to merge 1 commit intomasterfrom
enable-modernize

Conversation

@AnnaShaleva
Copy link
Member

Ref. https://ville.dev/blog/posts/go-modernize/. The support of gopls modernize tool is not available (ref.
golangci/golangci-lint#5466), but this modernize linter may be tried instead.

Let's give it a try and remove if it doesn't fit our needs.

Ref. https://ville.dev/blog/posts/go-modernize/. The support of gopls
modernize tool is not available (ref.
golangci/golangci-lint#5466), but this
`modernize` linter may be tried instead.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@roman-khimov
Copy link
Member

Needs to be tested on our codebase with fixes before merging it.

@AnnaShaleva
Copy link
Member Author

Confirmed to fix the same errors as modernize tool, check out the lint/tool output applied to NeoGo: https://github.com/nspcc-dev/neo-go/actions/runs/22489446332 (from nspcc-dev/neo-go@master...modernize):

Linter:
image
Tool:
image

@AnnaShaleva
Copy link
Member Author

https://github.com/nspcc-dev/hrw doesn't contain Makefile and doesn't need fixes.

@AnnaShaleva
Copy link
Member Author

As far as https://github.com/nspcc-dev/rfc6979.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants