[SUPPORT] Fix/Helper object broadcasting#2008
Merged
fyrchik merged 4 commits intonspcc-dev:support/v0.34from Nov 8, 2022
carpawell:fix/lock-objects-broadcasting
Merged
[SUPPORT] Fix/Helper object broadcasting#2008fyrchik merged 4 commits intonspcc-dev:support/v0.34from carpawell:fix/lock-objects-broadcasting
fyrchik merged 4 commits intonspcc-dev:support/v0.34from
carpawell:fix/lock-objects-broadcasting
Conversation
Contributor
|
I've tested scenario from #1973 with your changes and it seems to fix it. But when I tried to delete locked object from node2, which stored on node1, in error message we have only status code which indicates that object locked instead of human readable message: |
fyrchik
previously approved these changes
Nov 7, 2022
| contentGot, err := v.ValidateContent(obj) | ||
| require.NoError(t, err) // all good | ||
|
|
||
| require.EqualValues(t, []oid.ID{id}, contentGot.Objects()) |
Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Do not use node's local storage if it is clear that an object will be removed anyway as a redundant. It requires moving the changing local storage logic from the validation step to the local target implementation. It allows performing any relations checks (e.g. object locking) only if a node is considered as a valid container member and is expected to store (stored previously) all the helper objects (e.g. `LOCK`, `TOMBSTONE`, etc). Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Includes: 1. Unused func removal; 2. Err check of the `Sign` method. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## support/v0.34 #2008 +/- ##
=================================================
+ Coverage 30.54% 30.56% +0.02%
=================================================
Files 380 380
Lines 27800 27793 -7
=================================================
+ Hits 8492 8496 +4
+ Misses 18606 18596 -10
+ Partials 702 701 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fyrchik
approved these changes
Nov 7, 2022
This was referenced Nov 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1972.
Includes:
object lock'slifetimeflag fix;