Fix negative logic object counter#3555
Merged
roman-khimov merged 2 commits intomasterfrom Sep 3, 2025
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3555 +/- ##
==========================================
+ Coverage 25.03% 25.09% +0.06%
==========================================
Files 660 660
Lines 49411 49416 +5
==========================================
+ Hits 12372 12403 +31
+ Misses 36042 36015 -27
- Partials 997 998 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
reviewed
Sep 2, 2025
End-rey
force-pushed
the
3477-negative-logic-object-counter
branch
2 times, most recently
from
969d06a to
735404d
Compare
roman-khimov
approved these changes
Sep 3, 2025
End-rey
force-pushed
the
3477-negative-logic-object-counter
branch
from
735404d to
33ff78b
Compare
During `InhumeContainer`, the counter was taken for all objects, but it was needed only for those that were in the container. Add tests. Closes #3477. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
cthulhu-rider
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3477.