cli: Refactor usage of NeoFS API client#950
Merged
cthulhu-rider merged 1 commit intonspcc-dev:masterfrom Nov 3, 2021
Merged
Conversation
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-node
that referenced
this pull request
Nov 1, 2021
The client needs of the CLI application are limited and change not often. Interface changes of the client library should not affect the operation of various application packages, if they do not change their requirements for the provided functionality. To localize the use of the base client and facilitate further support, an auxiliary package is implemented that will only be used by the CLI application. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
refactor/cli-apiclient-usage
branch
from
3ecb68d to
cd07242
Compare
Codecov Report
@@ Coverage Diff @@
## master #950 +/- ##
==========================================
- Coverage 37.95% 37.76% -0.19%
==========================================
Files 255 256 +1
Lines 12948 13013 +65
==========================================
Hits 4915 4915
- Misses 7624 7689 +65
Partials 409 409
Continue to review full report at Codecov.
|
|
I'd suggest minimizing wrappers and reconsider this particular refactoring change. |
Contributor
Author
|
@realloc, there are no new wrappers or interfaces, only helper functions over |
The client needs of the CLI application are limited and change not often. Interface changes of the client library should not affect the operation of various application packages, if they do not change their requirements for the provided functionality. To localize the use of the base client and facilitate further support, an auxiliary package is implemented that will only be used by the CLI application. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
refactor/cli-apiclient-usage
branch
from
cd07242 to
b18cb38
Compare
Contributor
Author
|
I've built |
alexvanin
approved these changes
Nov 3, 2021
Contributor
alexvanin
left a comment
alexvanin
left a comment
There was a problem hiding this comment.
For neofs-cli, expect to see rollback with new SDK client invocation directly from application code.
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Mar 5, 2022
The client needs of the CLI application are limited and change not often. Interface changes of the client library should not affect the operation of various application packages, if they do not change their requirements for the provided functionality. To localize the use of the base client and facilitate further support, an auxiliary package is implemented that will only be used by the CLI application. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Mar 5, 2022
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #946