lib/softtoken/{sdb.c,sftkdbti.h}: Align sftkdb_known_attributes_size type#31
Closed
nvinson wants to merge 1 commit into
Closed
lib/softtoken/{sdb.c,sftkdbti.h}: Align sftkdb_known_attributes_size type#31nvinson wants to merge 1 commit into
nvinson wants to merge 1 commit into
Conversation
…type sftkdb_known_attributes_size is defined with conflicting types. In /lib/softtoken/sdb.c it is defined as a 'const size_t'; whereas in lib/softtoken/sftkdbti.h it is defined as an 'unsigned int'. The correct type for sftkdb_known_attributes_size is size_t since its value is derived from the size of the sftkdb_known_attributes array. Fixes: 1983399 Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
nvinson
changed the title
Collaborator
|
Hello, thank you for your PR. Feel free to ping me if you have any problems! |
Author
|
I have submitted the patch.
https://phabricator.services.mozilla.com/D261440
Thanks.
|
Collaborator
|
Lovely, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sftkdb_known_attributes_size is defined with conflicting types. In /lib/softtoken/sdb.c it is defined as a 'const size_t'; whereas in lib/softtoken/sftkdbti.h it is defined as an 'unsigned int'. The correct type for sftkdb_known_attributes_size is size_t since its value is derived from the size of the sftkdb_known_attributes array.
Fixes: 1983399