- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2
 
Language reference #29
Conversation
| More complex types can be built out of primitive ones: | ||
| 
               | 
          ||
| * Tuples: ``(type1, type2, ...)``. A tuple must have at least two fields. | ||
| * Structs: ``{ name1: type1, name2: type2, ... }`` | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to include
Sums: ``Name1 type1a ... | Name2 type2a ... | ...``
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason — I totally missed it. Thanks!
        
          
                reference/workflow_language.rst
              
                Outdated
          
        
      | ``A.y`` must be a function that produces "optional" (potentially missing) values, | ||
| in which case ``filter A.y`` is a function that filters out missing values. | ||
| 
               | 
          ||
| * Type application. Some functions (notably, sources and sinks) can be specialized | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"notably, some sources and sinks" / "notably, the built-in sources and sinks"? I don't think sources and sinks in general have to be polymorphic (The websocket ones aren't, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But "the built-in sources and sinks" is imprecise in exactly the same way, no?
Adding "some" works, though.
        
          
                reference/workflow_language.rst
              
                Outdated
          
        
      | ``self.args["foo"]``. | ||
| 
               | 
          ||
| The workflow language supports line and block comments. | ||
| Line comments start with ``--`` and extend until the end of line. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're // not --
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right — apparently Mandeep silently changed the comment syntax :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foiled by git blame :) sorry about that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
No description provided.