Skip to content

Use PowerShell DISM cmdlets#173

Merged
ntdevlabs merged 1 commit intontdevlabs:mainfrom
Ziron:powershell_dism
May 6, 2024
Merged

Use PowerShell DISM cmdlets#173
ntdevlabs merged 1 commit intontdevlabs:mainfrom
Ziron:powershell_dism

Conversation

@Ziron
Copy link
Copy Markdown
Contributor

@Ziron Ziron commented May 3, 2024

Call DISM through built-in powershell cmdlets instead of calling the dism.exe CLI utility.

For reference:
https://learn.microsoft.com/en-us/windows-hardware/manufacture/desktop/use-dism-in-windows-powershell-s14

Copy link
Copy Markdown

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ntdevlabs ntdevlabs merged commit f762e66 into ntdevlabs:main May 6, 2024
@dekart811
Copy link
Copy Markdown

This should be reverted, because -StartComponentCleanup for Repair-WindowsImage doesn't exist in Windows 10 22H2 or Windows 11 23H2. So Repair-WindowsImage -Path "$mainOSDrive\scratchdir" -StartComponentCleanup -ResetBase will always fail.
So the only way to build this right now properly is by using an Windows 11 insider build, which isn't a good idea IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants