fix(runt): use plist binary path for version check in doctor#1260
Merged
fix(runt): use plist binary path for version check in doctor#1260
Conversation
The version_match check was using default_binary_path() independently, which could resolve to the wrong binary (e.g., runt instead of runtimed when current_exe() is the runt CLI inside the app bundle). Now reuses the binary_path from the top of run_checks(), which on macOS reads from the plist (what launchd actually runs).
github-actions
Bot
added
the
daemon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runt daemon doctorversion_match check using the wrong binary path on macOSContext
Follow-up to #1256. The version_match check in doctor was calling
default_binary_path()independently, which resolves tocurrent_exe()when running from inside the app bundle. Sincecurrent_exe()isrunt(notruntimed),get_binary_version()failed and version_match showed[unknown] (installed binary not found).Now reuses the
binary_pathfrom the top ofrun_checks(), which on macOS reads from the plist (the actual runtimed binary that launchd runs).Test plan
env -i HOME=$HOME runt-nightly daemon doctorshows version_match as[ok]instead of[unknown]