fix(test): platform-conditional socket path assertion for Windows#1270
Merged
fix(test): platform-conditional socket path assertion for Windows#1270
Conversation
The test_daemon_config_default test asserts the socket path contains "runtimed.sock", which is only valid on Unix. On Windows, the daemon uses named pipes (\\.\pipe\runtimed) instead. Add #[cfg(unix)] and #[cfg(windows)] guards so each platform checks its own format.
github-actions
Bot
added
daemon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_daemon_config_defaultfails on Windows because it asserts the socket path contains"runtimed.sock"— a Unix domain socket filename. On Windows, the daemon uses named pipes (\\.\pipe\runtimed) instead, so the assertion never holds.Adds
#[cfg(unix)]and#[cfg(windows)]guards so each platform checks its own socket path format, matching the existing platform-conditional logic inrunt-workspace.Verification
cargo test -p runtimed test_daemon_config_defaultPR submitted by @rgbkrk's agent, Quill